-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: ckeditor bump to v4.17.0 (fixes #2751) #2752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Struggling to replicate the original issue, but the PR is working as expected.
The issue does not seem to happen consistently. From my own experience it's about 1 in 4 times, but I wonder if different browsers/OS will increase or decrease it. I've applied this PR to the site of the client that reported it and asked them to help test. I've refreshed a component page ten times and have not seen it yet, so seems to be working so far. I will approve tomorrow, assuming the client can't replicate again. |
I can only replicate on a new mcq. I imagine that any long schema will cause the _.defer to lapse before the rendered template is attached to the Dom, where ckeditor errors replacing an unattached textarea. The fix is to perform the ckeditor replacement of the textarea only after the parent element is attached to the body element. |
fixes #2751
Fixes