Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ckeditor bump to v4.17.0 (fixes #2751) #2752

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Fix: ckeditor bump to v4.17.0 (fixes #2751) #2752

merged 4 commits into from
Feb 23, 2024

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Feb 20, 2024

fixes #2751

Fixes

  • Bump version of ckeditor from v4.16.2 to v14.17.0
  • Wait for textarea to become attached to the dom before replacing with ckeditor

@oliverfoster oliverfoster added S: in-progress Issues currently being worked on - leave these be! C: Front-end Issues related to the front-end/UI labels Feb 20, 2024
@oliverfoster oliverfoster self-assigned this Feb 20, 2024
Copy link
Member

@taylortom taylortom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Struggling to replicate the original issue, but the PR is working as expected.

@simondate
Copy link
Member

The issue does not seem to happen consistently. From my own experience it's about 1 in 4 times, but I wonder if different browsers/OS will increase or decrease it.

I've applied this PR to the site of the client that reported it and asked them to help test.

I've refreshed a component page ten times and have not seen it yet, so seems to be working so far. I will approve tomorrow, assuming the client can't replicate again.

@oliverfoster
Copy link
Member Author

Struggling to replicate the original issue, but the PR is working as expected.

I can only replicate on a new mcq. I imagine that any long schema will cause the _.defer to lapse before the rendered template is attached to the Dom, where ckeditor errors replacing an unattached textarea. The fix is to perform the ckeditor replacement of the textarea only after the parent element is attached to the body element.

@taylortom taylortom merged commit 60c5b3d into master Feb 23, 2024
1 check passed
@taylortom taylortom deleted the issue/2751 branch February 23, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Front-end Issues related to the front-end/UI S: in-progress Issues currently being worked on - leave these be!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CK Editor not loading correctly
5 participants