Esp touch alarm fix #8003
Merged
Esp touch alarm fix #8003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this has to get into 8.1.0 final, so you don't have to merge even if you approve. It's been a bug since 7.2.0 or so. ... But probably safe to merge anyway. |
tannewt
approved these changes
May 22, 2023
|
Confirmed this fix works for me on the Qt Py ESP32-S2. Thank you @dhalbert for the quick solution. `Wi-Fi: off | code.py | 8.1.0-2-g9040ac8bcWi-Fi: off | code.py | 8.1.0-2-g9040ac8bc Press any key to enter the REPL. Use CTRL-D to reload. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two problems:
microcontroller/Pin.cto not reset just once. I was originally using never-reset to do this, but I can't always clear never-reset at the right time, so sometimes it sticks around and causes the pin to appear to be in use.TOUCH_FSM_MODE_TIMERtoTOUCH_FSM_MODE_SW.SWdoes not work with sleep touch awakening. I had changed it toSWin Fix ESP32 touch; rework common code a bit #6772, but I don't know why, andTIMERseems to work fine on ESP32, ESP32-S2, and ESP32-S3.Tested on Metro ESP32-S2, Feather ESP32-S3 8MB/no-psram, and Feather ESP32 V2.
ESP32
TouchAlarmwakeup does not work -- I spent several hours on it, and can't figure out why it's not working. I'll open another issue for that. ESP32TouchInworks fine. Some of my residual changes to help that along are in this PR, because the original code was clearly wrong in some cases.@mikeysklar you may want to test.
@rxhfcy did you encounter the original issue? You may want to test.