Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add particles #46

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Add particles #46

merged 2 commits into from
Mar 3, 2023

Conversation

brentru
Copy link
Member

@brentru brentru commented Mar 3, 2023

Brings Adafruit_Sensor in-line with https://github.com/adafruit/Wippersnapper_Protobuf/blob/master/proto/wippersnapper/i2c/v1/i2c.proto by adding support for PM10, PM25, PM100. Readings in ppm.

Resolves #40

@brentru brentru mentioned this pull request Mar 3, 2023
@brentru brentru merged commit 716fa39 into adafruit:master Mar 3, 2023
@brentru brentru deleted the add-particles branch March 3, 2023 18:04
@tyeth
Copy link
Contributor

tyeth commented Mar 3, 2023

@brentru In the description the PM100 value is <10.0, not 100, like the PM10 is <1.0 micron and PM25 is <2.5µm
I don't know if it's worth mentioning that these values are for upto, or less than, the value. This confuses matters because I don't know if the 4 micron value is included in the <10.0 value, which theoretically it should be for comparability with other devices that don't show <4.0 micron separately and only have a 2.5 and 10 micron value. pfff, don't worry for now apart from the first issue, and maybe adding less than or equals symbol and size unit could be good, but probably overkill

@brentru
Copy link
Member Author

brentru commented Mar 3, 2023

@tyeth Thanks for the review! I've updated master to reflect your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for particles...
2 participants