Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix captouch issue with incorrect send pin #70

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix captouch issue with incorrect send pin #70

merged 1 commit into from
Nov 30, 2023

Conversation

hathach
Copy link
Member

@hathach hathach commented Nov 28, 2023

fix adafruit/Adafruit_nRF52_Arduino#800 due to Captouch function make some issues with type value

  • sendPin is declared as uint8_t cannot be compared with -1, 255 is correct value
  • timeout check should also be >=, since while loop break with while < condition

@hathach hathach requested a review from ladyada November 28, 2023 08:54
@hathach hathach mentioned this pull request Nov 28, 2023
Closed
@hathach hathach requested a review from a team November 29, 2023 05:05
@hathach hathach merged commit 8bd8eb5 into master Nov 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada Awaiting requested review from ladyada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CircuitPlayground.readCap() not working with Bluefruit.begin()
1 participant
@hathach