Added GoCardless Integration for ING (Romania) #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… payeeName; Added Release note
actual-github-bot
bot
changed the title
spideraxal
changed the title
|
👋 Hi!
That's totally fine. We all have to start somewhere. Did you test this change locally to verify that it works to your satisfaction? Generally with custom bank-mappers I trust the authors to do the due diligence as there is very limited possibility for me to test this code on my own (since I'm not a customer of this bank). |
|
Yep, tested it with my own transactions. I still need to 100% confirm the pending transaction deduplication, which should happen in one or two days. I can update the post here before this gets approved. Also, @matt-fidd helped with the code, so I know this will work 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I created a custom adapter for ING Bank (Romania). Due to issues with how the transactionId is populated by the bank, new transactions would not be imported to Actual.
As I am not primarily a developer, feedback is greatly appreciated!