Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basics/basics to v4 #474

Merged
merged 4 commits into from
Feb 2, 2022
Merged

Update basics/basics to v4 #474

merged 4 commits into from
Feb 2, 2022

Conversation

LukeMathWalker
Copy link
Contributor

@LukeMathWalker LukeMathWalker commented Jan 28, 2022

It was pretty straight-forward, with a few exceptions:

  • The v4 documentation says that both Resource and Route can be used as default service, but that's not the case. Only Route is accepted;
  • actix-utils no longer has a mpsc module, so I had to work out what adapter was necessary to use tokio's types.

@LukeMathWalker
Copy link
Contributor Author

Related PR on actix-web to fix docs: actix/actix-web#2614

@robjtede robjtede merged commit 8dcc610 into actix:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants