Add support for tokio tracing for actix Service. #86
Conversation
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 58.38% 58.64% +0.25%
==========================================
Files 75 76 +1
Lines 4881 4967 +86
==========================================
+ Hits 2850 2913 +63
- Misses 2031 2054 +23
Continue to review full report at Codecov.
|
|
I'm not sure this should be in actix-net, not third-party crate. CC @fafhrd91 |
|
I asked Raj to add it to actix-net |
actix-tracing/src/lib.rs
Outdated
| /// Creates a new span for the given request value. | ||
| /// | ||
| /// By default, this function returns `None`. | ||
| fn span_for(&self, _req: &T) -> Option<tracing::Span> { |
There was a problem hiding this comment.
should be required method, no reason for default impl
actix-tracing/src/lib.rs
Outdated
| pub fn trace<S, U, T>( | ||
| service_factory: U, | ||
| make_span: T, | ||
| ) -> impl ServiceFactory< |
There was a problem hiding this comment.
it won't be possible to use +Clone with impl Trait here
There was a problem hiding this comment.
Not sure I understand this. I was able to add a Clone bound on the Fn.
There was a problem hiding this comment.
Resulted factory wouldn’t have clone even if input service factory would have clone
There was a problem hiding this comment.
Let’s return ApplyTransform type instead of impl ServiceFactory
There was a problem hiding this comment.
Changed the return type to ApplyTransform.
Still don't understand the Clone comment. The Clone bound is on the closure and not on the factory returned from trace.
There was a problem hiding this comment.
but if you want to make clonable service factory, it would be not possible with impl Trait
|
thanks! |
|
Any documentation yet for using this with |
No description provided.