normalize logs capital letter #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
reviewed
Jul 16, 2022
|
criterion's dependency started to use edition 2021, I think testing on MSRV has some benefits (e.g. making sure it works by tests), and bumping MSRV to 1.56 would be fine (actix-web's MSRV is 1.57, so it shouldn't make much difference IMO). @robjtede Any objections? |
robjtede
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Refactor / Code Style
PR Checklist
Check your PR fulfills the following:
(not sure if my pr should tick other boxes, although some words in docs/code style would probably help)
Overview
It seems that most packages in Rust uses lower case letters at the begging of the logs, and also Go code style recommends same style.
This crate uses a mix of upper and lower case, so I've decided to fix it to lower where appropriate.
I've searched for
debug/trace/info/warn/errorkeywords and changed the letters, if it isn't a common upper case abbreviation.