Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service improvements #233

Merged
merged 8 commits into from
Dec 27, 2020
Merged

service improvements #233

merged 8 commits into from
Dec 27, 2020

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Dec 27, 2020 •
edited
Loading

PR Type

Refactor

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

  • remove service benchmarks
  • add helper macros for poll_ready implementations
  • use pin-project-lite
  • enable #[no_std]
  • removes and_then_apply_fn because it's just sugar for .and_then(apply_fn(...)) and was causing issues with pin-project-lite

Base automatically changed from svc to master December 27, 2020 04:28
@robjtede robjtede changed the title remove old service benchmarks service improvements Dec 27, 2020
@robjtede robjtede marked this pull request as ready for review December 27, 2020 04:36
@robjtede robjtede requested review from a team December 27, 2020 04:41
ibraheemdev
ibraheemdev reviewed Dec 27, 2020
View reviewed changes
Copy link
Member

@ibraheemdev ibraheemdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

fakeshadow
fakeshadow approved these changes Dec 27, 2020
View reviewed changes
Copy link
Contributor

@fakeshadow fakeshadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robjtede robjtede merged commit 8a58a34 into master Dec 27, 2020
@robjtede robjtede deleted the svc-improvements branch December 27, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibraheemdev ibraheemdev ibraheemdev left review comments

@fakeshadow fakeshadow fakeshadow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robjtede @fakeshadow @ibraheemdev