Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move and update server+tls examples #190

Merged
merged 1 commit into from
Sep 13, 2020
Merged

move and update server+tls examples #190

merged 1 commit into from
Sep 13, 2020

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Sep 13, 2020

PR Type

Docs

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Format code with the latest stable rustfmt

Overview

A start on making these lower level primitives more accessible. Up until now the examples folder has not been part of any package and therefore hasn't been compile checked in CI.

This PR updates and documents the examples as well as generates a new key/cert pair for the TLS example. (Plus a couple docs tweaks that aren't important enough for changelog entries.)

@robjtede robjtede requested a review from a team September 13, 2020 03:21
@codecov

This comment has been minimized.

@robjtede robjtede added the documentation improvement/fix for documentation label Sep 13, 2020
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up until now the examples folder has not been part of any package and therefore hasn't been compile checked in CI.

Oh, I didn't notice that, looks good to me.

@robjtede robjtede merged commit fb0aa02 into master Sep 13, 2020
@robjtede robjtede deleted the server-examples branch September 13, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation improvement/fix for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants