feature(session): add deadpool-redis compatibility #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
0rangeFox
force-pushed
the
session-deadpool_redis-compatibility
branch
from
af23196 to
30b7402
Compare
…to skip the doc tests failure.
jayvdb
reviewed
Feb 14, 2024
jayvdb
reviewed
Feb 14, 2024
jayvdb
reviewed
Feb 14, 2024
jayvdb
reviewed
Feb 14, 2024
…oid shadowing, fix the wrong return type on builder function comment.
jayvdb
approved these changes
Feb 16, 2024
robjtede
reviewed
Jun 16, 2024
…rom the last merge?)
|
This is actually blocked on a new release of deadpool-redis with a redis v0.26 dependency update. |
rgrfoss
reviewed
Aug 6, 2024
robjtede
approved these changes
Aug 6, 2024
|
thanks for your work on this @0rangeFox 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
PR Checklist
cargo +nightly fmt).Overview
A new feature named
redis-dp-sessionhas been added, as well as the logic for accepting the deadpool-redis library in the redis-rs file, since deadpool-redis uses redis-rs in under the hood, so both are compatible and instead of duplicating, some attributes have been added to control the compilation of the features that are selected.