Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old PR template and update new template #917

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Remove old PR template and update new template #917

merged 2 commits into from
Jun 4, 2021

Conversation

benchislett
Copy link
Contributor

@benchislett benchislett commented Jun 4, 2021 •
edited by tatevikh
Loading

🚀 🚀 Pull Request

Changes

Updates the PR template. No code diff, so checklist is irrelevant.

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have added the description of proposed changes and its scope
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have linked the PR to an issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have described and made corresponding changes to the relevant docs folder
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings
  • I have kept the coverage-rate up

@benchislett benchislett requested a review from tatevikh June 4, 2021 22:17
@benchislett benchislett self-assigned this Jun 4, 2021
@codecov
Copy link

codecov bot commented Jun 4, 2021 •
edited
Loading

Codecov Report

Merging #917 (1d183ee) into master (b3ce438) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #917   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files          65       65           
  Lines        4770     4770           
=======================================
  Hits         4153     4153           
  Misses        617      617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ce438...1d183ee. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jun 4, 2021

Locust summary

Git references

Initial: b3ce438
Terminal: 1d183ee

@tatevikh tatevikh merged commit 770cc6b into master Jun 4, 2021
@tatevikh tatevikh deleted the update-pr-template branch June 4, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatevikh tatevikh tatevikh approved these changes

Assignees

@benchislett benchislett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benchislett @tatevikh