Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   64.30%   64.30%           
=======================================
  Files          39       39           
  Lines        1496     1496           
=======================================
  Hits          962      962           
  Misses        534      534           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbee965...8dd2222. Read the comment docs.

@prithviraj-maurya thanks for your contribution to Hub! There's a couple of other things mentioned in #44, including changes to the Coco example. It'd be great if you could do that as well and then test that everything's working fine by storing and loading the dataset. I've mentioned the details in the comments of #44. Let me know once that's one and we should be good to merge!

Does it satisfy all requirements now ??

@prithviraj-maurya thanks for the attempt. Some of the fixes that you made to the Coco dataset are incomplete and also syntactically incorrect at places.
For instance:-
"category_id": {"shape": (1,), "int64": "object", "chunksize": 1000} is incorrect.
It should be something like "category_id": {"shape": (1,), "dtype": "int64", "chunksize": 1000},

Other fields such as bbox, iscrowd also need to be changed in meta.
The same goes for all the fields being assigned np.empty(1, object) in the _call_ function.

Please make these changes. Then upload the dataset to hub and try loading it back to confirm that everything is working properly as described here:- #44 (comment)

Once this is done, it should be good to merge.

Please have a look now
What are the steps to upload the dataset ?

Hey @prithviraj-maurya - thank you so much for volunteering for more tasks! Here's a tutorial for uploading datasets using Hub that might be helpful for you! Once you've looked through the tutorial, please take a look at our issue dashboard to choose a dataset task that is not taken, or feel free to suggest a dataset of your own.

Is this PR still valid ?