Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Action CI/CD - Fixed issue #595 #820

Merged
merged 1 commit into from
May 19, 2021
Merged

GitHub Action CI/CD - Fixed issue #595 #820

merged 1 commit into from
May 19, 2021

Conversation

Anselmoo
Copy link
Contributor

@Anselmoo Anselmoo commented May 1, 2021

🚀 🚀 Pull Request

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is your Pull Requests linked to an Issue

New Feature Submissions:

  • Does your submission pass all tests?
  • Does your submission not lower the coverage-rate?
  • Have you lint your code locally prior to submission; including black style?

Summary

The GitHub-Action CI/CD is now running full unit and coverage test for all (forked) branches.

@Anselmoo
Fixed issue #595
834a643 
Fixed issue #595 by activating pytest and coverage
@github-actions
Copy link

github-actions bot commented May 1, 2021

Locust summary

Git references

Initial: 4f3bd32
Terminal: 834a643

@codecov
Copy link

codecov bot commented May 1, 2021 •
edited
Loading

Codecov Report

Merging #820 (834a643) into master (4f3bd32) will decrease coverage by 3.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
- Coverage   89.55%   85.70%   -3.85%     
==========================================
  Files          65       64       -1     
  Lines        4518     4512       -6     
==========================================
- Hits         4046     3867     -179     
- Misses        472      645     +173
Impacted Files Coverage Δ
hub/store/azure_fs.py 23.43% <0.00%> (-58.60%) ⬇️
hub/client/token_manager.py 61.11% <0.00%> (-27.78%) ⬇️
hub/store/s3_storage.py 61.33% <0.00%> (-24.01%) ⬇️
hub/client/hub_control.py 66.66% <0.00%> (-23.62%) ⬇️
hub/cli/auth.py 34.28% <0.00%> (-20.00%) ⬇️
hub/client/base.py 53.33% <0.00%> (-12.01%) ⬇️
hub/store/metastore.py 81.08% <0.00%> (-10.82%) ⬇️
hub/store/store.py 82.29% <0.00%> (-7.30%) ⬇️
hub/report.py 75.80% <0.00%> (-6.46%) ⬇️
hub/api/dataset_utils.py 89.50% <0.00%> (-6.18%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3bd32...834a643. Read the comment docs.

@Anselmoo Anselmoo marked this pull request as ready for review May 1, 2021 06:44
@Anselmoo Anselmoo changed the title Fixed issue #595 GitHub Action CI/CD - Fixed issue #595 May 11, 2021
@verbose-void verbose-void self-requested a review May 19, 2021 19:19
verbose-void
verbose-void approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@verbose-void verbose-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@verbose-void verbose-void merged commit 914b1b2 into activeloopai:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verbose-void verbose-void verbose-void approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anselmoo @verbose-void