Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for windows issues #528

Merged
merged 5 commits into from
Feb 4, 2021
Merged

Fixes for windows issues #528

merged 5 commits into from
Feb 4, 2021

Conversation

AbhinavTuli
Copy link
Contributor

@AbhinavTuli AbhinavTuli commented Feb 3, 2021

Fixes the windows issues faced by users. Closes #510 and #497

@github-actions
Copy link

github-actions bot commented Feb 3, 2021

Locust summary

Git references

Initial: ccbca36
Terminal: 7a0030e

hub/compute/transform.py
Changes:
hub/api/tests/test_dataset.py
Changes:
hub/schema/tests/test_features.py
Changes:
hub/schema/tests/test_tensor.py
Changes:

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #528 (911185d) into master (ccbca36) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #528   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files          52       52           
  Lines        3745     3745           
=======================================
  Hits         3313     3313           
  Misses        432      432           
Impacted Files Coverage Δ
hub/compute/transform.py 93.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccbca36...911185d. Read the comment docs.

@AbhinavTuli
Copy link
Contributor Author

@DebadityaPal @KrishnaChaitanya1 could you try out this branch on windows and let me know if it fixes your issues?
Use pip install -e . to install it

@AbhinavTuli AbhinavTuli merged commit 0128704 into master Feb 4, 2021
@AbhinavTuli AbhinavTuli deleted the fixes/windows_issues branch March 22, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Windows Support
1 participant