Hotfix for to_pytorch #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locust summaryGit referencesInitial: a394e9bTerminal: 6a0486d hub/api/dataset.pyChanges:
hub/schema/audio.pyChanges:
hub/schema/class_label.pyChanges:
hub/compute/transform.pyChanges:
hub/schema/image.pyChanges:
hub/schema/segmentation.pyChanges:
hub/schema/bbox.pyChanges:
hub/schema/mask.pyChanges:
hub/schema/polygon.pyChanges:
hub/schema/sequence.pyChanges:
hub/schema/text.pyChanges:
hub/schema/video.pyChanges:
hub/store/dynamic_tensor.pyChanges:
hub/api/tests/test_converters.pyChanges:
hub/api/tests/test_dataset.pyChanges:
hub/schema/tests/test_features.pyChanges:
hub/schema/tests/test_serilize_deserialize.pyChanges:
hub/store/tests/test_s3_storage.pyChanges:
hub/test_numcodecs.pyChanges:
|
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
==========================================
- Coverage 85.09% 85.07% -0.02%
==========================================
Files 49 49
Lines 3623 3625 +2
==========================================
+ Hits 3083 3084 +1
- Misses 540 541 +1
Continue to review full report at Codecov.
|
edogrigqv2
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #452.
We need a better fix for this, I've added a check for the Dataset mode which should solve it temporarily however the default mode in which a dataset is opened by non-owner is append, which should be changed to read.