Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deepmemory fixes #2675

Merged
merged 11 commits into from
Nov 4, 2023
Merged

Deepmemory fixes #2675

merged 11 commits into from
Nov 4, 2023

Conversation

adolkhan
Copy link
Contributor

@adolkhan adolkhan commented Oct 30, 2023

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  1. Changed default rate_limiter behavior, if it is not specified or partially specified we auto populate other parameters.
  2. Fixed docs
  3. Changed printings in deep_memory and made them more clear
  4. Changed deep_memory search to be local (temporary change, while tensor_db is not fixed)

Things to be aware of

Things to worry about

Additional Context

@adolkhan adolkhan marked this pull request as draft October 30, 2023 09:21
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (95786a3) 84.31% compared to head (62f842b) 83.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2675      +/-   ##
==========================================
- Coverage   84.31%   83.72%   -0.60%     
==========================================
  Files         231      231              
  Lines       25843    25856      +13     
==========================================
- Hits        21789    21647     -142     
- Misses       4054     4209     +155     
Flag Coverage Δ
unittests 83.72% <93.10%> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
deeplake/core/vectorstore/deep_memory.py 94.30% <100.00%> (+0.12%) ⬆️
deeplake/core/vectorstore/deeplake_vectorstore.py 95.79% <ø> (-0.21%) ⬇️
...eeplake/core/vectorstore/deepmemory_vectorstore.py 100.00% <ø> (ø)
...core/vectorstore/vector_search/dataset/__init__.py 100.00% <ø> (ø)
.../core/vectorstore/vector_search/dataset/dataset.py 95.98% <94.11%> (-0.20%) ⬇️
...ectorstore/vector_search/indra/search_algorithm.py 86.00% <83.33%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adolkhan adolkhan marked this pull request as ready for review October 31, 2023 12:58
docs/source/Deep-Memory.rst Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Nov 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.3% 93.3% Coverage
0.0% 0.0% Duplication

@adolkhan adolkhan merged commit fce0d9f into main Nov 4, 2023
11 of 12 checks passed
@adolkhan adolkhan deleted the deepmemory_fixes branch November 4, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants