Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep Memory virtual tensors support #2643

Merged
merged 12 commits into from
Oct 9, 2023
Merged

Conversation

adolkhan
Copy link
Contributor

@adolkhan adolkhan commented Oct 8, 2023

🚀 🚀 Pull Request

Impact

  • [X ] Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

In this PR I am adding support for retrieving score tensor during deep memory search and also fixing documentation failure related to VectorStore

Things to be aware of

Things to worry about

Additional Context

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (84e32e5) 84.33% compared to head (9ac475f) 83.77%.
Report is 2 commits behind head on main.

❗ Current head 9ac475f differs from pull request most recent head c9c67fe. Consider uploading reports for the commit c9c67fe to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2643      +/-   ##
==========================================
- Coverage   84.33%   83.77%   -0.57%     
==========================================
  Files         229      229              
  Lines       25494    25495       +1     
==========================================
- Hits        21501    21359     -142     
- Misses       3993     4136     +143     
Flag Coverage Δ
unittests 83.77% <100.00%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
deeplake/core/vectorstore/deep_memory.py 93.92% <100.00%> (ø)
deeplake/core/vectorstore/deeplake_vectorstore.py 96.15% <ø> (ø)
...ectorstore/vector_search/indra/search_algorithm.py 90.24% <100.00%> (+0.24%) ⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adolkhan adolkhan force-pushed the deep_memory_virtual_tensors_fix branch from 8f3fe06 to d1c326b Compare October 9, 2023 17:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@adolkhan adolkhan merged commit bdb7323 into main Oct 9, 2023
10 checks passed
@adolkhan adolkhan deleted the deep_memory_virtual_tensors_fix branch October 9, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants