Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose indra virtual tensors in deeplake #2350

Merged
merged 6 commits into from
May 16, 2023
Merged

Expose indra virtual tensors in deeplake #2350

merged 6 commits into from
May 16, 2023

Conversation

khustup
Copy link
Contributor

@khustup khustup commented May 13, 2023

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

  • Create DeeplakeQueryDataset based on TQL api if the query is filter or not.
  • If the tensor is not accessible in deeplake_ds try to get it from indra_ds.

@codecov
Copy link

codecov bot commented May 13, 2023 •
edited
Loading

Codecov Report

Patch coverage: 6.45% and project coverage change: -0.04 ⚠️

Comparison is base (bb61aaf) 84.57% compared to head (fbe8209) 84.54%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2350      +/-   ##
==========================================
- Coverage   84.57%   84.54%   -0.04%     
==========================================
  Files         298      298              
  Lines       35740    35786      +46     
==========================================
+ Hits        30228    30254      +26     
- Misses       5512     5532      +20
Flag Coverage Δ
unittests 84.54% <6.45%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
deeplake/core/dataset/deeplake_query_dataset.py 33.06% <0.00%> (-0.82%) ⬇️
deeplake/enterprise/libdeeplake_query.py 20.68% <0.00%> (ø)
setup.py 0.00% <0.00%> (ø)
deeplake/core/tests/test_deeplake_indra_dataset.py 11.41% <9.09%> (-0.26%) ⬇️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@levongh levongh merged commit 29e49b3 into main May 16, 2023
@levongh levongh deleted the indra-virtual-tensors branch May 16, 2023 03:45
@davidbuniat davidbuniat mentioned this pull request May 17, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adolkhan adolkhan adolkhan approved these changes

@levongh levongh levongh approved these changes

@farizrahman4u farizrahman4u Awaiting requested review from farizrahman4u

@FayazRahman FayazRahman Awaiting requested review from FayazRahman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khustup @levongh @adolkhan