[AL-2135] 3d bbox doc api #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatevikh
requested review from
FayazRahman,
AbhinavTuli,
farizrahman4u and
levongh
FayazRahman
suggested changes
Jan 27, 2023
|
|
||
| - ``length`` - is the length of the bounding box along x direction | ||
| - ``width`` - is the width of the bounding box along y direction | ||
| - ``height`` - is the height of the bounding box along z direction |
There was a problem hiding this comment.
also describe rot_x, -rot_z and rot_y
FayazRahman
reviewed
Jan 27, 2023
docs/source/Htypes.rst
Outdated
| - ``length`` - is the length of the bounding box along x direction | ||
| - ``width`` - is the width of the bounding box along y direction | ||
| - ``height`` - is the height of the bounding box along z direction | ||
| - ``rot_x`` - rotation angel along x axis, given in degrees |
There was a problem hiding this comment.
Suggested change
| - ``rot_x`` - rotation angel along x axis, given in degrees | |
| - ``rot_x`` - rotation angle along x axis, given in degrees |
FayazRahman
reviewed
Jan 27, 2023
docs/source/Htypes.rst
Outdated
| - ``width`` - is the width of the bounding box along y direction | ||
| - ``height`` - is the height of the bounding box along z direction | ||
| - ``rot_x`` - rotation angel along x axis, given in degrees | ||
| - ``rot_y`` - rotation angel along y axis, given in degrees |
FayazRahman
reviewed
Jan 27, 2023
docs/source/Htypes.rst
Outdated
|
|
||
| Bounding boxes are in KITTI format. In order for bounding boxes to be correctly displayed by the visualizer, the format of the bounding box should be as follows: | ||
|
|
||
| ``[x, y, z, length, width, hieght, rot_x, -rot_z, rot_y]`` |
There was a problem hiding this comment.
why does rot_z have a minus symbol? Also follow this same ordering in the descriptions below
Codecov ReportBase: 88.32% // Head: 88.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2145 +/- ##
==========================================
- Coverage 88.32% 88.23% -0.09%
==========================================
Files 291 287 -4
Lines 32059 31750 -309
==========================================
- Hits 28317 28016 -301
+ Misses 3742 3734 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
farizrahman4u
approved these changes
Jan 30, 2023
FayazRahman
reviewed
Jan 30, 2023
FayazRahman
approved these changes
Jan 30, 2023
adolkhan
force-pushed
the
bbox-3d-api-docs
branch
from
91250f1 to
1fb10c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Checklist:
coverage-rateupChanges
Docs API on 3d bbox