Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AL-2078] Switch random split doc section #2064

Merged
merged 9 commits into from
Dec 21, 2022
Merged

[AL-2078] Switch random split doc section #2064

merged 9 commits into from
Dec 21, 2022

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@AbhinavTuli AbhinavTuli changed the title Switch random split doc section [AL-2078] Switch random split doc section Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022 •
edited
Loading

Codecov Report

Base: 89.71% // Head: 86.24% // Decreases project coverage by -3.46% ⚠️

Coverage data is based on head (0d5bf30) compared to base (197573c).
Patch coverage: 91.34% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2064      +/-   ##
==========================================
- Coverage   89.71%   86.24%   -3.47%     
==========================================
  Files         271      273       +2     
  Lines       29833    29550     -283     
==========================================
- Hits        26764    25485    -1279     
- Misses       3069     4065     +996
Flag Coverage Δ
unittests 86.24% <91.34%> (-3.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
deeplake/integrations/tests/test_mmdet.py 13.29% <0.00%> (-84.93%) ⬇️
deeplake/util/scheduling.py 11.11% <0.00%> (-71.17%) ⬇️
deeplake/util/downsample.py 84.00% <84.00%> (ø)
deeplake/core/tensor_link.py 93.22% <92.10%> (-0.04%) ⬇️
deeplake/core/dataset/dataset.py 92.32% <94.11%> (-0.36%) ⬇️
deeplake/core/index/index.py 87.98% <94.11%> (+0.82%) ⬆️
deeplake/api/tests/test_downsample.py 95.55% <95.55%> (ø)
deeplake/api/tests/test_api.py 97.40% <100.00%> (-2.40%) ⬇️
deeplake/core/partial_sample.py 92.85% <100.00%> (+1.19%) ⬆️
deeplake/core/serialize.py 96.93% <100.00%> (+0.03%) ⬆️
... and 107 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@istranic
Copy link
Contributor

@AbhinavTuli Is there a way to only make this method available with pip install deeplake[enterprise]?

@AbhinavTuli AbhinavTuli merged commit 384b074 into main Dec 21, 2022
@AbhinavTuli AbhinavTuli deleted the random_split_enterprise branch December 21, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FayazRahman FayazRahman FayazRahman approved these changes

@levongh levongh levongh approved these changes

@farizrahman4u farizrahman4u Awaiting requested review from farizrahman4u

@istranic istranic Awaiting requested review from istranic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AbhinavTuli @istranic @levongh @FayazRahman