[DL-815] Unifying src_token and dest_token to token #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farizrahman4u
approved these changes
Dec 6, 2022
AbhinavTuli
reviewed
Dec 6, 2022
deeplake/util/exceptions.py
Outdated
|
|
||
|
|
||
| class UnsupportedParameterException(Exception): | ||
| def __init__(self, message): |
There was a problem hiding this comment.
Suggested change
| def __init__(self, message): | |
| pass |
AbhinavTuli
approved these changes
Dec 6, 2022
FayazRahman
suggested changes
Dec 6, 2022
deeplake/api/dataset.py
Outdated
|
|
||
| Returns: | ||
| Dataset: New dataset object. | ||
|
|
||
| Raises: | ||
| DatasetHandlerError: If a dataset already exists at destination path and overwrite is False. | ||
| UnsupportedParameterException: If parameter that is no longer supported is beeing called. |
There was a problem hiding this comment.
Suggested change
| UnsupportedParameterException: If parameter that is no longer supported is beeing called. | |
| UnsupportedParameterException: If a parameter that is no longer supported is specified. |
docs/source/deeplake.api.dataset.rst
Outdated
| @@ -27,11 +27,11 @@ deeplake.api.dataset | |||
|
|
|||
| See :func:`deeplake.like`. | |||
|
|
|||
| .. staticmethod:: copy(src: Union[str, pathlib.Path, Dataset], dest: Union[str, pathlib.Path], tensors: Optional[List[str]] = None, overwrite: bool = False, src_creds=None, src_token=None, dest_creds=None, dest_token=None, num_workers: int = 0, scheduler="threaded", progressbar=True) | |||
| .. staticmethod:: copy(src: Union[str, pathlib.Path, Dataset], dest: Union[str, pathlib.Path], tensors: Optional[List[str]] = None, overwrite: bool = False, src_creds=None dest_creds=None, num_workers: int = 0, scheduler="threaded", progressbar=True) | |||
docs/source/deeplake.api.dataset.rst
Outdated
|
|
||
| See :func:`deeplake.copy`. | ||
|
|
||
| .. staticmethod:: deepcopy(src: Union[str, pathlib.Path], dest: Union[str, pathlib.Path], tensors: Optional[List[str]] = None, overwrite: bool = False, src_creds=None, src_token=None, dest_creds=None, dest_token=None, num_workers: int = 0, scheduler="threaded", progressbar=True, public: bool = False, verbose: bool = True) | ||
| .. staticmethod:: deepcopy(src: Union[str, pathlib.Path], dest: Union[str, pathlib.Path], tensors: Optional[List[str]] = None, overwrite: bool = False, src_creds=None, dest_creds=None, num_workers: int = 0, scheduler="threaded", progressbar=True, public: bool = False, verbose: bool = True) |
FayazRahman
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Checklist:
coverage-rateupChanges
Changed src_token, dest_token to token in copy and deepcopy