Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AL-2017] Add decode method to Pytorch API #1991

Merged
merged 29 commits into from
Nov 15, 2022
Merged

[AL-2017] Add decode method to Pytorch API #1991

merged 29 commits into from
Nov 15, 2022

Conversation

AbhinavTuli
Copy link
Contributor

@AbhinavTuli AbhinavTuli commented Nov 8, 2022 •
edited
Loading

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

  • Adds decode method to experimental dataloader API
  • Adds decode method to python dataloader API
  • Experimental -> Enterprise
  • New API for using Experimental features
  • [TODO] Update libdeeplake version before merging

@AbhinavTuli AbhinavTuli changed the title Add decode method to Pytorch API [AL-2017] Add decode method to Pytorch API Nov 8, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022 •
edited
Loading

Codecov Report

Base: 89.65% // Head: 89.66% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b0967af) compared to base (9581ab0).
Patch coverage: 55.68% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1991   +/-   ##
=======================================
  Coverage   89.65%   89.66%           
=======================================
  Files         253      253           
  Lines       27764    27816   +52     
=======================================
+ Hits        24893    24942   +49     
- Misses       2871     2874    +3
Flag Coverage Δ
unittests 89.66% <55.68%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
deeplake/core/transform/transform.py 97.72% <ø> (ø)
deeplake/enterprise/test_query.py 16.27% <ø> (ø)
deeplake/enterprise/util.py 18.91% <ø> (ø)
deeplake/integrations/pytorch/pytorch.py 87.50% <ø> (-0.38%) ⬇️
deeplake/enterprise/test_pytorch.py 24.05% <5.26%> (ø)
deeplake/core/dataset/dataset.py 92.15% <20.00%> (-0.13%) ⬇️
deeplake/enterprise/dataloader.py 18.43% <23.80%> (ø)
deeplake/core/linked_chunk_engine.py 87.37% <33.33%> (-1.29%) ⬇️
deeplake/core/chunk/sample_compressed_chunk.py 97.77% <50.00%> (-1.09%) ⬇️
deeplake/core/chunk_engine.py 94.52% <50.00%> (-0.13%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AbhinavTuli AbhinavTuli marked this pull request as ready for review November 14, 2022 07:47
FayazRahman and others added 6 commits November 15, 2022 10:13
@FayazRahman
[DL-895] Enterprise API reference (#2006)
eadf129 
* init

* update

* docstrings

* update docs

* fix

* fixes

* fix pytorch docstring

* fix error

* update eval docs

* eval doc

* add note

* darg
@AbhinavTuli
fix legacy dataloaders
5a56361
@AbhinavTuli
Merge remote-tracking branch 'origin' into decode
7e20f8e
@AbhinavTuli
add linting
2507583
@AbhinavTuli
lint fixes
f022cdb
@AbhinavTuli
mypy fix
72c2209
@AbhinavTuli AbhinavTuli merged commit 9d2c9a3 into main Nov 15, 2022
@AbhinavTuli AbhinavTuli deleted the decode branch November 15, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FayazRahman FayazRahman FayazRahman approved these changes

@levongh levongh levongh approved these changes

@farizrahman4u farizrahman4u Awaiting requested review from farizrahman4u

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhinavTuli @levongh @FayazRahman