Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DL-761] mesh htype support #1940

Merged
merged 7 commits into from
Dec 9, 2022
Merged

[DL-761] mesh htype support #1940

merged 7 commits into from
Dec 9, 2022

Conversation

adolkhan
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Added support for ply extension of point cloud + refactored code related to point cloud

@tatevikh tatevikh changed the title Dl 761 [DL-761] Oct 14, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022 •
edited
Loading

Codecov Report

Base: 89.59% // Head: 89.90% // Increases project coverage by +0.30% 🎉

Coverage data is based on head (d731804) compared to base (eaab7f1).
Patch coverage: 92.61% of modified lines in pull request are covered.

❗ Current head d731804 differs from pull request most recent head 992ce52. Consider uploading reports for the commit 992ce52 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1940      +/-   ##
==========================================
+ Coverage   89.59%   89.90%   +0.30%     
==========================================
  Files         253      260       +7     
  Lines       27844    27359     -485     
==========================================
- Hits        24947    24596     -351     
+ Misses       2897     2763     -134
Flag Coverage Δ
unittests 89.90% <92.61%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
deeplake/api/tests/test_api.py 99.79% <ø> (+<0.01%) ⬆️
deeplake/core/dataset/dataset.py 92.74% <ø> (+0.80%) ⬆️
deeplake/core/serialize.py 97.27% <ø> (+0.37%) ⬆️
deeplake/util/exceptions.py 84.57% <33.33%> (-0.67%) ⬇️
deeplake/core/sample.py 87.25% <66.66%> (-0.09%) ⬇️
deeplake/util/object_3d/object_base_3d.py 75.00% <75.00%> (ø)
deeplake/util/object_3d/read_3d_data.py 84.61% <84.61%> (ø)
deeplake/util/object_3d/ply_parsers.py 88.00% <88.00%> (ø)
deeplake/util/object_3d/ply_parser_base.py 91.17% <91.17%> (ø)
deeplake/util/object_3d/mesh.py 92.18% <92.18%> (ø)
... and 102 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

levongh
levongh reviewed Oct 26, 2022
View reviewed changes
docs/source/Compressions.rst Outdated
@@ -24,6 +24,8 @@ are given below.
+----------------+----------------+----------------------------------------+
| Point Cloud | point_cloud | ``las`` |
+----------------+----------------+----------------------------------------+
| Mesh | mesh | `ply` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct the quotes

@adolkhan adolkhan changed the title [DL-761] [DL-761] mesh htype support Oct 31, 2022
@tatevikh tatevikh requested a review from FayazRahman November 2, 2022 14:19
@adolkhan adolkhan requested a review from levongh November 3, 2022 04:21
FayazRahman
FayazRahman reviewed Nov 10, 2022
View reviewed changes
deeplake/api/tests/test_point_cloud.py Outdated
@@ -70,6 +71,9 @@ def test_point_cloud(local_ds, point_cloud_paths):
20153,
3,
)

local_ds.point_cloud_without_sample_compression.numpy(aslist=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary line

@adolkhan adolkhan merged commit e0328b9 into main Dec 9, 2022
@adolkhan adolkhan deleted the DL-761 branch December 9, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FayazRahman FayazRahman FayazRahman left review comments

@levongh levongh levongh approved these changes

@farizrahman4u farizrahman4u farizrahman4u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adolkhan @farizrahman4u @levongh @FayazRahman @as-engineer