[Bug fix] Fixes boto3 credentials reload issue in hub compute #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhinavTuli
commented
Mar 23, 2022
| if isinstance(storage, MemoryProvider): | ||
| storages = [storage] * len(slices) | ||
| else: | ||
| storages = [storage.copy() for _ in slices] |
There was a problem hiding this comment.
creating proper copies of storage to prevent reuse of boto3 resource across workers
AbhinavTuli
commented
Mar 23, 2022
| self.client = boto3.client("s3", **args) | ||
| self.resource = boto3.resource("s3", **args) | ||
| session = boto3.session.Session(profile_name=self.profile_name) | ||
| self.client = session.client("s3", **args) |
There was a problem hiding this comment.
instantiating from session instead of boto3.client makes this threadsafe
FayazRahman
approved these changes
Mar 23, 2022
Codecov Report
@@ Coverage Diff @@
## main #1562 +/- ##
==========================================
+ Coverage 92.34% 92.36% +0.01%
==========================================
Files 199 199
Lines 17939 17943 +4
==========================================
+ Hits 16566 16573 +7
+ Misses 1373 1370 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
farizrahman4u
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Checklist:
coverage-rateupChanges