Lint with Black on GitHub Actions and format with Black #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hugovk thanks a lot for the PRs and really appreciate your contribution! To make the PRs meaningful under #Hacktoberfest guidelines, would be great if you could combine #134, #135, #137 into single one. I would be happy to run a circleci test and merge it. On another note, if you are interested and would like to contribute further I can create a separate issue to automate package building on github and we can count that as a separate PR. |
|
Sure, sounds good to both suggestions! |
And fix a typo
This was referenced Oct 25, 2020
Locust summaryGit referencesInitial: 7a400c3Terminal: 501a927 hub/collections/dataset/core.pyChanges:
hub/client/auth.pyChanges:
hub/client/hub_control.pyChanges:
hub/client/token_manager.pyChanges:
hub/collections/tensor/core.pyChanges:
test/benchmark/old/imagenet_train.pyChanges:
test/benchmark/old/multiprocess_benchmark.pyChanges:
hub/client/base.pyChanges:
test/benchmark/old/baseline.pyChanges:
examples/fashion-mnist/train_pytorch.pyChanges:
hub/exceptions.pyChanges:
examples/coco/upload_coco2017.pyChanges:
examples/fashion-mnist/train_tf_fit.pyChanges:
examples/fashion-mnist/train_tf_gradient_tape.pyChanges:
examples/fashion-mnist/upload.pyChanges:
examples/mnist/upload.pyChanges:
hub/cli/auth.pyChanges:
hub/cli/utils.pyChanges:
hub/collections/client_manager.pyChanges:
hub/collections/dataset/__init__.pyChanges:
hub/collections/tensor/__init__.pyChanges:
hub/log.pyChanges:
hub/utils.pyChanges:
test/benchmark/basic_train.pyChanges:
|
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 64.30% 64.30%
=======================================
Files 39 39
Lines 1496 1496
=======================================
Hits 962 962
Misses 534 534
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/activeloopai/Hub/blob/master/CONTRIBUTING.md says:
However, the code is not Black formatted.
Let's format it!
And let's go a step further, and add linting on CI using GitHub Actions to make sure the code remains formatted.
It does it using pre-commit, so if people like, they can use
pip install pre-commit && pre-commit installto have it automatically run Black during commit. This is optional though.