Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes empty samples in hub compute #1269

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Fixes empty samples in hub compute #1269

merged 2 commits into from
Oct 19, 2021

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

farizrahman4u
farizrahman4u approved these changes Oct 18, 2021
View reviewed changes
hub/util/transform.py Outdated
@@ -129,6 +129,8 @@ def transform_data_slice_and_append(
posixpath.join(group_index, k): result[k] for k in result.tensors
}
result = result_resolved # type: ignore
if len(result.keys()) == 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if len(result.keys()) == 0:
if not results:

@codecov
Copy link

codecov bot commented Oct 18, 2021 •
edited
Loading

Codecov Report

Merging #1269 (586a032) into main (cacc657) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1269      +/-   ##
==========================================
- Coverage   91.60%   91.58%   -0.02%     
==========================================
  Files         138      138              
  Lines        9506     9521      +15     
==========================================
+ Hits         8708     8720      +12     
- Misses        798      801       +3
Impacted Files Coverage Δ
hub/core/transform/test_transform.py 96.26% <100.00%> (+0.20%) ⬆️
hub/util/transform.py 90.08% <100.00%> (+0.33%) ⬆️
hub/core/lock.py 84.44% <0.00%> (-6.67%) ⬇️
hub/core/storage/s3.py 73.41% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cacc657...586a032. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit 7b00f2b into main Oct 19, 2021
@AbhinavTuli AbhinavTuli deleted the fix/compute_empty branch October 19, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verbii-1 verbii-1 verbii-1 approved these changes

@farizrahman4u farizrahman4u farizrahman4u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AbhinavTuli @CLAassistant @farizrahman4u @verbii-1