Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creating nested tensor from non-head node #1261

Merged
merged 9 commits into from
Oct 18, 2021
Merged

Fix creating nested tensor from non-head node #1261

merged 9 commits into from
Oct 18, 2021

Conversation

FayazRahman
Copy link
Contributor

@FayazRahman FayazRahman commented Oct 14, 2021 •
edited
Loading

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Fixed nested tensor creation from non-head node bug: #1260

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #1261 (265d13c) into main (8bf5534) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1261      +/-   ##
==========================================
+ Coverage   91.60%   91.63%   +0.02%     
==========================================
  Files         138      138              
  Lines        9506     9513       +7     
==========================================
+ Hits         8708     8717       +9     
+ Misses        798      796       -2
Impacted Files Coverage Δ
hub/core/dataset.py 92.22% <ø> (-0.03%) ⬇️
hub/api/tests/test_api.py 99.39% <100.00%> (+<0.01%) ⬆️
hub/client/utils.py 67.21% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bf5534...265d13c. Read the comment docs.

@farizrahman4u farizrahman4u merged commit a015ac2 into activeloopai:main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhinavTuli AbhinavTuli AbhinavTuli approved these changes

@farizrahman4u farizrahman4u farizrahman4u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FayazRahman @CLAassistant @farizrahman4u @AbhinavTuli