Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to override "Remove" button text on has_many forms #6523

Merged
merged 3 commits into from
Nov 19, 2020
Merged

Add ability to override "Remove" button text on has_many forms #6523

merged 3 commits into from
Nov 19, 2020

Conversation

littleforest
Copy link
Contributor

Closes #5283

  • Adds new option on a has_many form to override the "Remove" button text
  • Adds a new feature spec to test this functionality
  • Updates documentation

@littleforest littleforest force-pushed the 5283-override-remove-button-text branch from 3ac386d to 4a31c2f Compare October 24, 2020 22:02
@littleforest littleforest force-pushed the 5283-override-remove-button-text branch from 4a31c2f to fbd300e Compare October 25, 2020 00:02
deivid-rodriguez
deivid-rodriguez approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

javierjulio
javierjulio approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@javierjulio javierjulio merged commit b5b89ce into activeadmin:master Nov 19, 2020
@littleforest littleforest deleted the 5283-override-remove-button-text branch November 20, 2020 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deivid-rodriguez deivid-rodriguez deivid-rodriguez approved these changes

@javierjulio javierjulio javierjulio approved these changes

Assignees
No one assigned
Labels
type enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Override text of "Remove" button from has_many form builder for specified resource
3 participants
@littleforest @javierjulio @deivid-rodriguez