Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all pinned versions of ruby/setup-ruby to latest #1869

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Update all pinned versions of ruby/setup-ruby to latest #1869

merged 2 commits into from
Dec 20, 2022

Conversation

mattxwang
Copy link
Contributor

Hey! I'm a maintainer for a Jekyll theme (just-the-docs). We suggest users to use the starter workflow in this repo; however, someone has correctly pointed out that the current pinned version for ruby/setup-ruby, v1.115.3, emits a deprecation warning.

The maintainers for ruby/setup-ruby responded to this in ruby/setup-ruby#385 and released a fix in v1.118. At the minimum, I think we should update the example in this repository so that users don't encounter this problem; I've also took the liberty of updating it to the latest version, but happy to revert to 118 if we'd prefer.

Some metadata about the ruby/setup-ruby update:

  • latest commit version: 1.127.0
  • latest commit hash: ee2113536afb7f793eed4ce60e8d3b26db912da4

Not sure if the rest of the checklist items below apply to this, since it's a trivial upgrade (see: #1702, which motivated this). If it's necessary for me to apply to the GitHub Partner program and/or do anything else, do let me know!

Pre-requisites

N/A

  • Prior to submitting a new workflow, please apply to join the GitHub Technology Partner Program: partner.github.com/apply.

Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.


Tasks

For all workflows, the workflow:

  • Should be contained in a .yml file with the language or platform as its filename, in lower, kebab-cased format (for example, docker-image.yml). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").
  • Should use sentence case for the names of workflows and steps (for example, "Run tests").
  • Should be named only by the name of the language or platform (for example, "Go", not "Go CI" or "Go Build").
  • Should include comments in the workflow for any parts that are not obvious or could use clarification.
  • Should specify least privileged permissions for GITHUB_TOKEN so that the workflow runs successfully.

For CI workflows, the workflow:

  • Should be preserved under the ci directory.
  • Should include a matching ci/properties/*.properties.json file (for example, ci/properties/docker-publish.properties.json).
  • Should run on push to branches: [ $default-branch ] and pull_request to branches: [ $default-branch ].
  • Packaging workflows should run on release with types: [ created ].
  • Publishing workflows should have a filename that is the name of the language or platform, in lower case, followed by "-publish" (for example, docker-publish.yml).

For Code Scanning workflows, the workflow:

  • Should be preserved under the code-scanning directory.
  • Should include a matching code-scanning/properties/*.properties.json file (for example, code-scanning/properties/codeql.properties.json), with properties set as follows:
    • name: Name of the Code Scanning integration.
    • creator: Name of the organization/user producing the Code Scanning integration.
    • description: Short description of the Code Scanning integration.
    • categories: Array of languages supported by the Code Scanning integration.
    • iconName: Name of the SVG logo representing the Code Scanning integration. This SVG logo must be present in the icons directory.
  • Should run on push to branches: [ $default-branch, $protected-branches ] and pull_request to branches: [ $default-branch ]. We also recommend a schedule trigger of cron: $cron-weekly (for example, codeql.yml).

Some general notes:

  • This workflow must only use actions that are produced by GitHub, in the actions organization, or
  • This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be published to the GitHub Marketplace. We require that these actions be referenced using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file:
    # This workflow uses actions that are not certified by GitHub.
    # They are provided by a third-party and are governed by
    # separate terms of service, privacy policy, and support
    # documentation.
    
  • Automation and CI workflows should not send data to any 3rd party service except for the purposes of installing dependencies.
  • Automation and CI workflows cannot be dependent on a paid service or product.

Latest commit version: 1.127.0
Latest commit hash: ee2113536afb7f793eed4ce60e8d3b26db912da4

Motivating reason: version 1.118 fixes an actions/core deprecation warning; see release: https://github.com/ruby/setup-ruby/releases/tag/v1.118.0
and motivating issue: ruby/setup-ruby#385
@mattxwang mattxwang requested review from a team as code owners December 18, 2022 08:04
@github-actions github-actions bot requested a review from anuragc617 December 18, 2022 08:04
@github-actions github-actions bot added the code-scanning Related to workflows that show on the Code Scanning setup page label Dec 18, 2022
@mattxwang
Copy link
Contributor Author

FYI - I didn't touch the files that fail the lint. Not sure what's going on there, any help is appreciated!

Copy link
Contributor

@yoannchaudet yoannchaudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for Pages.

@bishal-pdMSFT Was the linter added recently?

@SamMorrowDrums
Copy link
Contributor

Looks good for code scanning workflow

@SamMorrowDrums
Copy link
Contributor

Yeah, looks like it's cleaning up old whitespace, and that should have presumably been fixed when introducing the linter 🤷‍♂️image.

@SamMorrowDrums
Copy link
Contributor

@yoannchaudet @bishal-pdMSFT I fixed it. There were problems with the version of the plugin on CI it seems. Even after I fixed it locally on my machine I was still getting failed linter on CI, but now I've pushed my change and updated the action on the default branch, the CI passes so I will go ahead and merge this.

@SamMorrowDrums SamMorrowDrums merged commit 65ce1d1 into actions:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-scanning Related to workflows that show on the Code Scanning setup page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants