Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to actions/checkout@v3 #437

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Bump to actions/checkout@v3 #437

merged 2 commits into from
Apr 1, 2022

Conversation

magnetikonline
Copy link
Contributor

@magnetikonline magnetikonline commented Mar 8, 2022 •
edited
Loading

Description:

  • Bump actions/checkout to @v3
  • Also noted (and bumped) actions/upload-artifact to @v3 (released after I cut this PR).

https://github.com/actions/checkout/releases/tag/v3.0.0

Related issue:
N/A

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@magnetikonline
Copy link
Contributor Author

ping @brcrista

@vsafonkin
Copy link

Hi @magnetikonline, perhaps, it would be better to include these changes to #433 , what do you think?

@magnetikonline
Copy link
Contributor Author

Hi @magnetikonline, perhaps, it would be better to include these changes to #433 , what do you think?

thanks @vsafonkin - typically I like to keep these PRs as small a changeset as possible so they are easier to reason with - hence the dual PRs - but if it's easier - can certainly combine them.

@brcrista
Copy link
Contributor

I went ahead and merged #433, so we can just move forward with this one separately. Looks like there are some merge conflicts now.

@magnetikonline magnetikonline requested a review from a team April 1, 2022 02:53
@magnetikonline
Copy link
Contributor Author

Done @brcrista - just re-created from main and added a bump for actions/upload-artifact too.

@magnetikonline
Copy link
Contributor Author

Hrm - noted one of the Yarn 2 e2e tests is now failing. Can't see how these changes introduce this issue?

Screen Shot 2022-04-01 at 2 01 59 pm

@dmitry-shibanov
Copy link
Contributor

Hello @magnetikonline. Thank you for your pull request. I think it was a random issue. I've resolved it by rerunning. Is pull request ready?

@magnetikonline
Copy link
Contributor Author

Wonderful @dmitry-shibanov - yeah all tests now passing 👍

Ready for approval/merge.

@dmitry-shibanov dmitry-shibanov merged commit 7571663 into actions:main Apr 1, 2022
@magnetikonline magnetikonline mentioned this pull request Apr 1, 2022
Merged
2 tasks
@magnetikonline magnetikonline deleted the bump-checkout-action branch April 1, 2022 08:26
@dmitry-shibanov dmitry-shibanov mentioned this pull request Apr 5, 2022
Closed
2 tasks
ghost
ghost reviewed May 7, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsafonkin

deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023
@dependabot
chore(deps-dev): bump typescript from 4.8.3 to 4.8.4 (actions#437)
f309cf5 
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.8.3 to 4.8.4.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.8.3...v4.8.4)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-shibanov dmitry-shibanov dmitry-shibanov approved these changes

@vsafonkin vsafonkin vsafonkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@magnetikonline @vsafonkin @brcrista @dmitry-shibanov