Throw error only if exit code is no zero. #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsafonkin
approved these changes
Nov 18, 2021
nikita-bykov
approved these changes
Nov 18, 2021
MaksimZhukov
approved these changes
Dec 23, 2021
dmitry-shibanov
changed the title
dmitry-shibanov
changed the title
This was referenced Dec 30, 2021
deining
pushed a commit
to deining/setup-node
that referenced
this pull request
Nov 9, 2023
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.5.4 to 4.5.5. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.5.4...v4.5.5) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
CrispyBaguette
pushed a commit
to CrispyBaguette/wasm-palette-converter
that referenced
this pull request
Nov 8, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://github.com/actions/setup-node) | action | patch | `v2.5.0` -> `v2.5.2` | --- ### Release Notes <details> <summary>actions/setup-node (actions/setup-node)</summary> ### [`v2.5.2`](https://github.com/actions/setup-node/releases/tag/v2.5.2): Update @​actions/core for v2 [Compare Source](actions/setup-node@v2.5.1...v2.5.2) In scope of this release we updated actions/core to 1.10.0 and actions/tool-cache to 1.7.2 for v2: actions/setup-node#713 ### [`v2.5.1`](https://github.com/actions/setup-node/releases/tag/v2.5.1): Fix logic of error handling for npm warning and uncaught exception [Compare Source](actions/setup-node@v2.5.0...v2.5.1) In scope of this release we fix logic of error handling related to caching (actions/setup-node#358) and (actions/setup-node#359). In the previous behaviour we relied on `stderr` output to throw error. The warning messages from package managers can be written to the stderr's output. For now the action will throw an error only if exit code differs from zero. Besides, we add logic to сatch and log unhandled exceptions. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xNDIuNSIsInVwZGF0ZWRJblZlciI6IjM4LjE0Mi41IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Reviewed-on: https://gitea.bruyant.xyz/alexandre/PaletteSwitcher/pulls/38 Co-authored-by: Renovate <renovate@bruyant.xyz> Co-committed-by: Renovate <renovate@bruyant.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In scope of this pull request we resolve the issue related to warning can produce error. Sometimes warning can be written to stderr output, but exit code is 0. We have to add a check to throw error only if exit code is not null.
Related issue:
Check list: