Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node-version instead of version #28

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Use node-version instead of version #28

merged 2 commits into from
Aug 13, 2019

Conversation

damccorm
Copy link
Contributor

No description provided.

@damccorm damccorm merged commit dd2e8a4 into master Aug 13, 2019
@damccorm damccorm deleted the version-input branch August 13, 2019 20:32
@soerface
Copy link

soerface commented Aug 19, 2019

@damccorm Is it possible to make pull requests for the GitHub help pages? Just saw that here, the deprecated "version" instead of "node-version" is used, I would like to update it: https://help.github.com/en/articles/workflow-syntax-for-github-actions#example-7

@damccorm
Copy link
Contributor Author

I don't believe that repo is open sourced to avoid confusion since it has docs for non-released products. I added a PR there though.

@soerface
Copy link

Thanks! Can you fix the lonely $, too? It needs to be something like ${{ matrix.node-version }} / ${{ matrix.os }}. Is there a place to report errors in the GitHub help, so I won't need to continue bothering you in this pull request? ;)

@damccorm
Copy link
Contributor Author

Can you fix the lonely $, too?

Yep

Is there a place to report errors in the GitHub help, so I won't need to continue bothering you in this pull request?

I'm actually not 100% sure where the best place for Action docs bugs is, @rachmari can you help there?

In general, filing an issue in this repo or one of the other https://github.com/actions/ repos will probably get the job done, I'll definitely follow up and PR or route as appropriate.

Thanks for the feedback here as well, definitely helps :)

krzyk pushed a commit to krzyk/setup-node that referenced this pull request Apr 11, 2023
deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants