Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for NODE_AUTH_TOKEN overwritten #205

Merged
merged 10 commits into from
Dec 16, 2020
Merged

Check for NODE_AUTH_TOKEN overwritten #205

merged 10 commits into from
Dec 16, 2020

Conversation

zodman
Copy link
Contributor

@zodman zodman commented Oct 21, 2020 •
edited
Loading

the updated version of #83

If i set the NODE_AUTH_TOKEN and then execute the àctions/setup-node the NODE_AUTH_TOKEN was overwriten with XXXXX and lost my variable value.

What actually fix this:

      - run: echo "NODE_AUTH_TOKEN=${{secrets.PAT}}" >> $GITHUB_ENV
      - name: Use Node.js 12.x
        uses: actions/setup-node@v2.1.2
        with:
          node-version: 12.x
          registry-url: https://npm.pkg.github.com/
          scope: '@foo'
      - run: echo "NODE_AUTH_TOKEN=${{secrets.PAT}}" >> $GITHUB_ENV

With the patch

      - run: echo "NODE_AUTH_TOKEN=${{secrets.PAT}}" >> $GITHUB_ENV
      - name: Use Node.js 12.x
        uses: actions/setup-node@v2.1.2
        with:
          node-version: 12.x
          registry-url: https://npm.pkg.github.com/
          scope: '@foo'

@zodman zodman changed the title adding test for NODE_AUTH_TOKEN overwritten Check for NODE_AUTH_TOKEN overwritten Oct 22, 2020
@nikita-bykov
Copy link

nikita-bykov commented Dec 14, 2020 •
edited by maxim-lobanov
Loading

Hello @zodman! Thank you for your contribution! We apologize that the review takes too long.
Your changes generally look good for us. Please pull the latest changes from the main branch, rebuild dist file and after that we can merge the PR.

@zodman
Copy link
Contributor Author

zodman commented Dec 15, 2020

@maxim-lobanov pulled last changes ..

@maxim-lobanov maxim-lobanov merged commit d06286d into actions:main Dec 16, 2020
@maxim-lobanov
Copy link
Contributor

@zodman thank you for contribution!

This was referenced Dec 16, 2020
Closed
Closed
This was referenced Mar 7, 2021
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Merged
This was referenced Mar 15, 2021
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023
@dependabot
chore(deps-dev): bump @typescript-eslint/eslint-plugin (actions#205)
2591f68 
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.23.0 to 4.24.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.24.0/packages/eslint-plugin)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaksimZhukov MaksimZhukov MaksimZhukov approved these changes

@maxim-lobanov maxim-lobanov maxim-lobanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zodman @nikita-bykov @maxim-lobanov @MaksimZhukov