Arch option for setup-node #194
Conversation
Co-Authored-By: Tyler Ang-Wanek <tylerw@axosoft.com>
Co-Authored-By: Tyler Ang-Wanek <tylerw@axosoft.com>
Co-Authored-By: Tyler Ang-Wanek <tylerw@axosoft.com>
aminya
force-pushed
the
arch
branch
2 times, most recently
from
5766020 to
551eb1b
Compare
Co-Authored-By: Tyler Ang-Wanek <tylerw@axosoft.com>
aminya
force-pushed
the
arch
branch
9 times, most recently
from
fe0bf32 to
b9d10d1
Compare
aminya
force-pushed
the
arch
branch
2 times, most recently
from
5e1a013 to
5e72f0c
Compare
aminya
force-pushed
the
arch
branch
2 times, most recently
from
5a63445 to
26c2a8c
Compare
Co-Authored-By: Tyler Ang-Wanek <tylerw@axosoft.com> feat: add nock Co-Authored-By: Tyler Ang-Wanek <tylerw@axosoft.com>
|
@aminya thanks for the quick response! |
This considers self-hosted runners
|
For testings, I want to make sure we're using the e2e workflow. For jest unit testing, make sure stuff is mocked - I believe it currently runs without actually downloading etc and will run/pass even with no internet connection. In other words, the unit tests are testing any biz logic and the e2e workflow actually tests everything e2e. |
As for the unit-testing, I think it is true for this PR. It should be just a separate job for windows-latest that will use specific Node.js version and x86 arch |
aminya
force-pushed
the
arch
branch
8 times, most recently
from
aca1c4f to
b6ad594
Compare
|
I added the e2e test. @maxim-lobanov Hopefully, this is ready to go now! |
|
@aminya , thank you for contribution and sorry that it took so much time to review it. I will take care about releasing new version soon |
Bumps [prettier](https://github.com/prettier/prettier) from 2.2.1 to 2.3.0. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.2.1...2.3.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This adds an option for choosing the architecture for the Node executable.
Closes #190
Closes #42
Edit:
For anyone who is waiting to use this before @actions finally review this: I have tagged the PR on my fork. You can use it right now.
https://github.com/atom-ide-community/fuzzaldrin-plus-fast/blob/master/.github/workflows/CI.yml
See the readme for another example: https://github.com/aminya/setup-node/tree/arch
Edit 2:
Unfortunately, I made this PR against the main branch which has a security bug. Use the above fork at your own risk.
See this for more information: #212