follow proxy settings #105
Conversation
| - name: Verify node version | ||
| run: __tests__/verify-node-version.sh 10 | ||
|
|
||
| test-proxy: |
| "@actions/io": "^1.0.0", | ||
| "@actions/tool-cache": "^1.0.0", | ||
| "typed-rest-client": "^1.5.0", | ||
| "@actions/core": "^1.2.2", |
There was a problem hiding this comment.
i updated all the toolkit packages
| let rest: restm.RestClient = new restm.RestClient('setup-node'); | ||
| let nodeVersions: INodeVersion[] = | ||
| (await rest.get<INodeVersion[]>(dataUrl)).result || []; | ||
| let httpClient = new hc.HttpClient('setup-node', [], { |
There was a problem hiding this comment.
i added retries here when downloading the versions JSON
further below when the exe is downloaded, toolCache.downloadTool already has retries built-in
| version: 10.x | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: Setup node 12 |
There was a problem hiding this comment.
Thanks. I had this on my TODO list to update ;)
|
the code changes LGTM. However, as I review the changes and see the endless node_modules diffs, I wonder if we just shouldn't do the ncc build as part of this change. I think we should do the change, point |
| "jest": "^24.8.0", | ||
| "jest-circus": "^24.7.1", | ||
| "prettier": "^1.17.1", | ||
| "ts-jest": "^24.0.2", | ||
| "typescript": "^3.5.1" | ||
| }, |
|
LGTM - I have some thoughts about pack vs build but let's take as a separate discussion. |
package.json
Outdated
| @@ -3,12 +3,14 @@ | |||
| "version": "1.0.0", | |||
|
@bryanmacfarlane are you suggesting |
|
actually i forgot, should format happen before pack. i wonder if |
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
No description provided.