-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement "check-latest" flag to check if pre-cached version is latest one #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaksimZhukov
approved these changes
Feb 2, 2022
vsafonkin
approved these changes
Feb 3, 2022
konradpabjan
approved these changes
Feb 4, 2022
brcrista
reviewed
Feb 7, 2022
brcrista
reviewed
Feb 7, 2022
brcrista
reviewed
Feb 7, 2022
brcrista
reviewed
Feb 8, 2022
- name: npm install | ||
run: npm install | ||
- name: npm ci | ||
run: npm ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
brcrista
reviewed
Feb 8, 2022
brcrista
reviewed
Feb 8, 2022
brcrista
reviewed
Feb 8, 2022
brcrista
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a few more small things, but otherwise 🚢
panticmilos
pushed a commit
to panticmilos/setup-go
that referenced
this pull request
Aug 4, 2022
n33pm
pushed a commit
to n33pm/setup-go
that referenced
this pull request
Oct 17, 2022
adilhusain-s
pushed a commit
to adilhusain-s/setup-go
that referenced
this pull request
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In scope of this pull request we add support for
check-latest
input. Ifcheck-latest
is set totrue
, the action first checks if the cached version is the latest one in go-versions repository. If the locally cached version is not the most up-to-date, a Go version will then be downloaded.Additional changes:
setup-node@v1
action's tag was changed tosetup-node@v2
in check-dist.ymllicensed.yml
.npm install
command was changed tonpm ci
in theworkflow.yml
.Related issue: #73
Check list: