Limit storageaccount name length to 24 characters #5396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-cheb
reviewed
Apr 12, 2022
|
|
||
|
|
||
| # Storage Account Name can only be 24 characters long | ||
| $storageAccountName = $storageAccountName.Substring(0, 24) |
There was a problem hiding this comment.
You should check if the length of storageAccountName is more than 24:
PS > "ahbfff".Substring(0, 24)
MethodInvocationException: Exception calling "Substring" with "2" argument(s): "Index and length must refer to a location within the string. (Parameter 'length')"
There was a problem hiding this comment.
Somehow missed this completely. Added a check for the length
al-cheb
approved these changes
Apr 13, 2022
dmitry-shibanov
approved these changes
Apr 13, 2022
miketimofeev
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If resource group name is long then the script will generate storage account name that's longer than 24 characters.
This change will limit the generated storageaccountname to 24 characters.
Document about limits