Check if service exists before stopping it (Linux) #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to check the service behaviour on macOS |
TingluoHuang
reviewed
Jun 7, 2021
TingluoHuang
reviewed
Jun 7, 2021
TingluoHuang
approved these changes
Jun 7, 2021
|
Make sure you tested before merging the PR. |
Tested successfully on Linux 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1022
If the runner was installed as a service but disabled using anything else than
svc.sh uninstall, runningsvc.sh uninstallnow will fail and it never deletes.servicein the runner's home folder. This in turn prevents users from runningconfig.sh remove, because the runner will think it's still configured as a service.This PR changes
svc.sh uninstallon Linux so it deletes.serviceeven is the service no longer exists.