Wait for debugger to attach in Runner.Worker process #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only if GITHUB_ACTIONS_RUNNER_ATTACH_DEBUGGER is set
hross
reviewed
May 20, 2021
src/Runner.Worker/Program.cs
Outdated
| private static async Task WaitForDebugger(Tracing trace) | ||
| { | ||
| trace.Info($"Waiting for a debugger to be attached. Edit the 'GITHUB_ACTIONS_RUNNER_ATTACH_DEBUGGER' environment variable to toggle this feature."); | ||
| while (!Debugger.IsAttached) |
There was a problem hiding this comment.
can we wait for some max time in case you don't attach a debugger
There was a problem hiding this comment.
Sure, I'm thinking 30s would probably be appropriate.
TingluoHuang
approved these changes
May 26, 2021
hydai
added a commit
to WasmEdge/WasmEdge
that referenced
this pull request
Aug 16, 2021
…s/checkout#334 Signed-off-by: hydai <hydai@secondstate.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stalls the Runner.Worker process until a debugger is connected if
GITHUB_ACTIONS_RUNNER_ATTACH_DEBUGGERenvironment variable is set to true.Related to #1023