Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to include zstd workaround for windows. #912

Merged
merged 9 commits into from
Aug 30, 2022
Merged

Update README to include zstd workaround for windows. #912

merged 9 commits into from
Aug 30, 2022

Conversation

lvpx
Copy link
Contributor

@lvpx lvpx commented Aug 25, 2022

This PR contains the following changes:

  1. Move Cache segment restore timeout section to Know practices and workarounds
  2. Add yaml formatting for actions code blocks
  3. Add zstd workaround for windows and zstd requirement for self-hosted windows runners.

@lvpx lvpx requested a review from a team as a code owner August 25, 2022 13:23
@github-actions github-actions bot requested a review from Phantsure August 25, 2022 13:23
@lvpx lvpx changed the title Pdotl/readme update 1 Update README to include zstd workaround for windows. Aug 25, 2022
@wrexbe
Copy link

wrexbe commented Aug 26, 2022 •
edited
Loading

This doesn't fix it. Even in your own test, this doesn't fix it
https://github.com/pdotl/sample-cache-demo/runs/7959974880?check_suite_focus=true
The "Cache Python virtualenv" step on Ubuntu took 2 seconds, and on Windows it took 11 seconds.
That is more then 5 times slower on windows, even with a tiny cache. If the cache is bigger, that difference becomes much worse.

@lvpx
Copy link
Contributor Author

lvpx commented Aug 26, 2022

Hi @wrexbe, I agree. This workaround is being used by customers vs using gzip which is even slower. We are simply documenting the same. We are looking into improving windows performance for cache by looking at several alternatives.

@lvpx lvpx requested a review from bishal-pdMSFT August 29, 2022 05:44
Phantsure
Phantsure reviewed Aug 29, 2022
View reviewed changes
README.md

## Known practices and workarounds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to create separate file for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would yes. We can move it to another file.

Phantsure
Phantsure approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@Phantsure Phantsure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvpx lvpx merged commit b195c99 into main Aug 30, 2022
@lvpx lvpx deleted the pdotl/readme-update-1 branch August 30, 2022 09:08
This was referenced Sep 30, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phantsure Phantsure Phantsure approved these changes

@bishal-pdMSFT bishal-pdMSFT Awaiting requested review from bishal-pdMSFT

Assignees

@Phantsure Phantsure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lvpx @wrexbe @Phantsure