Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3, the data model was changed to not provide a
__hash__
method if__eq__
is overriden in a class. PartialDate defines__eq__
but not__hash__
and is thus unhashable. To quote the docs,(from https://docs.python.org/3.7/reference/datamodel.html#object.__hash__)
We store PartialDate's in a set in SIR so it would be nice to make it hashable.