Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contact form added #26

Merged
merged 1 commit into from
Mar 20, 2022
Merged

contact form added #26

merged 1 commit into from
Mar 20, 2022

Conversation

Dipesh123-ux
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@rkapoor10 rkapoor10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dipesh the code looks fine just go through the following suggestions.


btn.addEventListener('click',(e)=>{

console.log("click");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console.log from deployment code

}

emailjs.send('service_qup666f','template_s8dkykn',tempParams).then((res)=>{
console.log("email sent successfully",res.status);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console.log

subject : document.getElementById("subject").value
}

emailjs.send('service_qup666f','template_s8dkykn',tempParams).then((res)=>{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try block?

console.log("click");

e.preventDefault();
var tempParams = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use const instead of var if every time a new object is created

@@ -0,0 +1,29 @@

var btn = document.getElementById('submit');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use const

@@ -898,7 +895,7 @@ <h5 class="text-uppercase py-md-2">Phone</h5>
</div>
<div class="icon_box_content">
<h5 class="text-uppercase py-md-2">Email</h5>
<p>jecjabalpur.acm@gmail.com</p>
<p>info@jecacm.com</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct mail id to acmjec3@gmail.com

@rkapoor10 rkapoor10 merged commit b4f2784 into acmjec:main Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants