Apply the name of the archive only to the result of buildPlugin task #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recently encountered the very same issue when trying to update another plugin, but was unable to diagnose at the time. I thought maybe it was a problem with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose that this question was regarding the name of the resulting plugin archive.
With the existing script, the naming rule will apply to the all zip tasks, which is incorrect. This fact causes the problem that AceJump currently has a bit "incorrect" structure and even IJ plugin marketplace resolved it fine, it's a bit tricky to make a dependency to AceJump.
intellijsection in gradle script just cannot resolve such structure and it's needed to add the dependency manually.This pull request reduces the naming rule only to the result of the
buildPlugintask.Additionally, here is a pic of the existing plugin structure:
And here is a fixed structure: