Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dictionary implementation in core #297

Merged
merged 26 commits into from
Mar 16, 2021

Conversation

rokasramas
Copy link
Member

@rokasramas rokasramas commented Mar 8, 2021

Closes #229 and #228 - will add structural words as dictionary items

@codecov-io
Copy link

codecov-io commented Mar 9, 2021

Codecov Report

Merging #297 (26f427d) into master (9cf99ad) will increase coverage by 4.48%.
The diff coverage is 95.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
+ Coverage   68.29%   72.77%   +4.48%     
==========================================
  Files          88       91       +3     
  Lines        3441     4129     +688     
  Branches      189      197       +8     
==========================================
+ Hits         2350     3005     +655     
- Misses        902      927      +25     
- Partials      189      197       +8     
Flag Coverage Δ
api 66.26% <ø> (ø)
core 79.24% <95.21%> (+7.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
core/src/acc_text/nlg/paradigms/lang/eng.clj 95.10% <95.10%> (ø)
core/src/acc_text/nlg/dictionary/item.clj 81.81% <100.00%> (ø)
core/src/acc_text/nlg/generator.clj 98.82% <100.00%> (+0.02%) ⬆️
core/src/acc_text/nlg/paradigms/lang.clj 100.00% <100.00%> (ø)
core/src/acc_text/nlg/paradigms/utils.clj 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cf99ad...26f427d. Read the comment docs.

@rokasramas rokasramas marked this pull request as ready for review March 15, 2021 15:26
@rokasramas rokasramas merged commit a322f9b into master Mar 16, 2021
@rokasramas rokasramas deleted the 229-upgrade-dictionary-implementation-in-core branch March 16, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dictionary item implementation in core
2 participants