Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Typescript definition file, adding to build #31

Conversation

mstlaurent-paradigm
Copy link
Contributor

Resolves issue #18

@ferrao
Copy link
Member

ferrao commented Jul 10, 2019

@mstlaurent-paradigm newer versions have aditional toast options, can you please add the missing ones?

@mstlaurent-paradigm
Copy link
Contributor Author

@ferrao Pull request updated

@ferrao
Copy link
Member

ferrao commented Aug 1, 2019

Thank you for your contribution @mstlaurent-paradigm, will update dependencies and publish a new version soon.

@ferrao ferrao merged commit f3f3266 into academia-de-codigo:master Aug 1, 2019
@ferrao
Copy link
Member

ferrao commented Aug 1, 2019

@mstlaurent-paradigm eslint is throwing the following error on index.d.ts:

2:5  error  Parsing error: Imports within a `declare module` body must always be `import typ
e` or `import typeof`

Do you think you can fix it before I publish a new release?

@mstlaurent-paradigm
Copy link
Contributor Author

Hey @ferrao, I've been looking into this issue, but I can't seem to find a fix. Do you have any suggestions?

@ferrao
Copy link
Member

ferrao commented Aug 1, 2019

No idea @mstlaurent-paradigm, I have zero knowledge of typescript and not very keen on investing time on it just yet ;)

Have reconfigured eslint to target .js files only as a workaround and have published a new version.

@mstlaurent-paradigm mstlaurent-paradigm deleted the master_TypescriptDefinitions branch August 2, 2019 13:16
@ferrao ferrao mentioned this pull request Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants