Fixing the "locate at" field in the html report #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ooglemapsgmm artifacts.
The field was being populated with the last file_found read so it was the same everywhere
|
Great catch! Thanks! 💖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the "locate at" field in the html report for the fitbit and googlemapsgmm artifacts.
The field was being populated with the last file_found read so it was the same everywhere even if the artifacts was from an other.
Ex : The Google Maps Label Places report was showing "Google Maps Label Places located at: z:\temp\data\data\com.google.android.apps.maps\databases\gmm_storage.db" and the artifcat came from "z:\temp\data\data\com.google.android.apps.maps\databases\gmm_myplaces.db"