Fix `avy-goto-subword-0' leading chars ordering #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't like adding another argument to Also, do you have an Emacs copyright assignment? Only 15 lines are allowed without it. |
* avy-jump.el (avy-goto-subword-0): Collect candidates by the ordering of the window. Fixed #14.
|
Yes. I've signed Emacs copyright assignment. |
|
So the issue currently isn't with the current window, it's just with the order of the other windows? |
abo-abo
added a commit
that referenced
this pull request
May 9, 2015
|
See if this |
|
Yes. The issue is with the order of the other window. |
abo-abo
added a commit
that referenced
this pull request
May 9, 2015
|
|
|
OK, hopefully this is the last iteration. |
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reversed window list.
Fixed #14.
According to `window-list' documentation, the selected window
will appear on the first item in the list. So I revert e931071.
In `avy-goto-subword-0', the candidates had been collected in natural
order per window. If we traverse in reversed windows list, the leading
char will be in correct order across multiple windows.