Update codemirror theme to match overall style/color scheme of the page #36
+65
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply Sweep Rules to your PR?
|
|
I like the dark theme. Feel free to do this on your own fork or would appreciate a PR with a settings options in dialog between the 2 themes so the user can select which theme they want but defaulting to black. |
|
@abi I just updated it to have the settings option |
|
@kachbit awesome work, thank you! ❤️ Would love any other contributions that you'd like to make. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the jarring "cobalt" theme with a pleasant "espresso" theme in the codemirror editor.
Before:
After:
I also added a border around the editor that matches the border seen in the "Desktop" and "Mobile" tabs