Add websites from jekyll/wiki/sites #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@decagon Super awesome! Could you please share the script you used to check the "health" of the links? |
|
I just adapted some code from this SO answer: http://stackoverflow.com/questions/12199059
However, there are some websites which show "This domain is available" however it doesn't return a 404 error, so this script wouldn't be able to detect that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extracts the websites from https://github.com/jekyll/jekyll/wiki/sites
I also did a quick URL check on each of the links; if one didn't respond for more than 20 seconds (i.e no data sent to client at all within that timeframe) then it was removed from the list.